Merge branch 'refactor/audit-fixes-and-dynamic-rbac-permissions' into 'develop'

feat: implement authentication module with registration, login, verification,...

See merge request !10

.env.example

 NODE_ENV=development
-PORT=3000
+PORT=9898
 TRUST_PROXY=false
 
 # Database Configuration (PostgreSQL / Supabase)

src/config/env.config.ts

 export const envConfig = {
   nodeEnv: process.env.NODE_ENV || "development",
-  port: parseInt(process.env.PORT || "3000", 10),
+  port: parseInt(process.env.PORT || "9898", 10),
   trustProxy: process.env.TRUST_PROXY || "false",
   database: {
     host: process.env.DB_HOST || "localhost",

src/modules/auth/__tests__/auth.service.test.ts

@@ -209,7 +209,7 @@ describe("AuthService registration mail failures", () => {
       );
     });
 
-    it("returns { success: true } and does not call mail service if user is not found", async () => {
+    it("throws 404 NOT_FOUND and does not call mail service if user is not found", async () => {
       const service = new AuthService();
       const repository = {
         findByEmail: jest.fn().mockResolvedValue(null),
@@ -224,15 +224,15 @@ describe("AuthService registration mail failures", () => {
       mutableService.repository = repository;
       mutableService.mailService = mailService;
 
-      const result = await service.forgotPassword({
+      await expect(
+        service.forgotPassword({
           email: "nonexistent@example.com",
-      });
-
-      expect(result).toEqual({ success: true });
+        })
+      ).rejects.toThrow("Email không tồn tại trong hệ thống.");
       expect(mailService.sendPasswordResetEmail).not.toHaveBeenCalled();
     });
 
-    it("returns { success: true } and does not call mail service if user is inactive", async () => {
+    it("throws 403 USER_INACTIVE and does not call mail service if user is inactive", async () => {
       const service = new AuthService();
       const repository = {
         findByEmail: jest
@@ -249,9 +249,9 @@ describe("AuthService registration mail failures", () => {
       mutableService.repository = repository;
       mutableService.mailService = mailService;
 
-      const result = await service.forgotPassword({ email: activeUser.email });
-
-      expect(result).toEqual({ success: true });
+      await expect(
+        service.forgotPassword({ email: activeUser.email })
+      ).rejects.toThrow("Tài khoản chưa được kích hoạt hoặc đã bị khóa.");
       expect(mailService.sendPasswordResetEmail).not.toHaveBeenCalled();
     });
   });

src/modules/auth/auth.controller.ts

@@ -330,8 +330,7 @@ export class AuthController {
 
       res.json({
         success: true,
-        message:
-          "If the email exists in our system, a password reset link has been sent.",
+        message: "Đường dẫn đặt lại mật khẩu đã được gửi đến email của bạn.",
       });
     } catch (error) {
       next(error);

src/modules/auth/auth.service.ts

@@ -607,8 +607,20 @@ export class AuthService {
     const { email } = data;
     const user = await this.repository.findByEmail(email);
 
-    if (!user || !user.isActive) {
-      return { success: true };
+    if (!user) {
+      throw new AppError(
+        "Email không tồn tại trong hệ thống.",
+        404,
+        ERROR_CODE.NOT_FOUND,
+      );
+    }
+
+    if (!user.isActive) {
+      throw new AppError(
+        "Tài khoản chưa được kích hoạt hoặc đã bị khóa.",
+        403,
+        ERROR_CODE.USER_INACTIVE,
+      );
     }
 
     const secret = `${jwtConfig.accessSecret}-${user.passwordHash}`;